Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates references to "journalists" in Source Interface to more neutral "team" #5175

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

wbaid
Copy link
Contributor

@wbaid wbaid commented Mar 30, 2020

Status

Ready for review

Description of Changes

Closes #5146.

  • Replaces instances of the phrase "our journalist[s]" with the phrase "our team", to reduce possible confusion when a source encounters a non-newsroom SecureDrop instance.

Testing

Observe the changed strings in the source interface's templates.

Deployment

No special considerations.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

@zenmonkeykstop
Copy link
Contributor

From a technical perspective there are no issues with this change. One concern might be that the move to more neutral language might make the purpose of the codename and gpg key less clear to sources. @ninavizz, any thoughts on UX impact of this change?

@ninavizz
Copy link
Member

ninavizz commented Apr 1, 2020

I generally dislike use of the word "staff," however it could carry stronger implications of safety via implied NDAs and commitment to ethics, than the more broad "team." However, "team" is likely more accurate—as some instances may well be run by volunteers, with all-volunteer orgs being high on my list for probable candidates.

TL;DR, yes, this is a great change. Thx for the ping @zenmonkeykstop ! :)

@zenmonkeykstop zenmonkeykstop changed the title chore: s/journalists/team Updates references to "journalists" in Source Interface to more neutral "team" Apr 1, 2020
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on diff review and input from UX maven.

@zenmonkeykstop zenmonkeykstop merged commit 77978fb into freedomofpress:develop Apr 1, 2020
@zenmonkeykstop zenmonkeykstop mentioned this pull request Apr 29, 2020
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for overriding interface strings
3 participants