Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.2.1 upgrade testing boxes #5136

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Add 1.2.1 upgrade testing boxes #5136

merged 1 commit into from
Feb 24, 2020

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Feb 21, 2020 •
edited by conorsch
Loading

Status

Ready for review

Description of Changes

Adds 1.2.1 upgrade testing boxes.

Closes #5121.

Testing

  • Checkout develop
  • make build-debs
  • Check out this branch
  • make upgrade-start (will take a while as it needs to fetch the boxes)
  • source interface shows SecureDrop version 1.2.1
  • make upgrade-test-local completes without error
  • source interface shows SecureDrop version 1.3.0~rc1

Deployment

Dev only.

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

@rmol rmol force-pushed the upgrade-boxes-1.2.1 branch from 2f33828 to e836059 Compare February 21, 2020 22:26
@rmol rmol changed the base branch from develop to release/1.2.1 February 21, 2020 22:27
@rmol rmol force-pushed the upgrade-boxes-1.2.1 branch from e836059 to 95c3e58 Compare February 21, 2020 22:33
@rmol rmol self-assigned this Feb 24, 2020
@conorsch
Copy link
Contributor

Reviewing...

conorsch
conorsch approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stepped through test plan locally, all good 👍

@conorsch conorsch merged commit bce606b into release/1.2.1 Feb 24, 2020
@rmol rmol mentioned this pull request Feb 24, 2020
Closed
@conorsch conorsch mentioned this pull request Feb 24, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

@emkll emkll Awaiting requested review from emkll

@kushaldas kushaldas Awaiting requested review from kushaldas

@heartsucker heartsucker Awaiting requested review from heartsucker

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

@zenmonkeykstop zenmonkeykstop Awaiting requested review from zenmonkeykstop

Assignees

@rmol rmol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release SecureDrop 1.2.1
2 participants
@rmol @conorsch