Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing Journalist Interface template files to apache2 apparmor profile #5088

Merged

Conversation

zenmonkeykstop
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop commented Jan 3, 2020

Status

Ready for review

Description of Changes

Fixes #5086 .

Added

Testing

  • Check out this branch and use the Molecule upgrade scenario to set up a test env with apparmor:
    make build-debs
    make upgrade-start
    make upgrade-test-local
    
  • log in to the app server with molecule login -s upgrade -h app-staging and set up an admin account, then retrieve the JI service info from /var/lib/tor/services/journalist/hostname
  • add a HidServAuth line to your local Tor Browser's torrc with the JI details
  • start Tor Browser and log in to the Ji
    • if you run into problems with logging in due to mismatched codes, you may need to generate the code on the app server itself. First install oathtool via apt and then use the command oathtool -b --totp "<shared secret here>"
  • visit the admin section and change the submisison preferences. You should get a confirmation flash message and no application error
  • visit http://<JI address>/iamapotato. You should get a 404 page, not an application error.

Deployment

No special deployment steps required.

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected.

  • visit the admin section and change the submisison preferences. You should get a confirmation flash message and no application error
  • visit http://<JI address>/iamapotato. You should get a 404 page, not an application error.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Journalist Interface template files not included in apparmor config
2 participants