Replaced duplicate updater message modal with syslog call #5067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
requested review from
kushaldas and
redshiftzero
as code owners
rmol
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
👍
- Check out this branch on a Tails Admin Workstation (VM or physical) with an admin password set.
- Open a terminal and run
sudo journalctl -f | grep SecureDropUpdater - Open a second terminal and run
python3 ~/Persistent/securedrop/journalist_gui/SecureDropUpdater- verify that the GUI updater appears - Open a third terminal and run
python3 ~/Persistent/securedrop/journalist_gui/SecureDropUpdater- verify that the GUI updater does not appear, and a line "SecureDrop Workstation Updater is already running" is logged in the first terminal - in the running GUI updater, click Update Now and verify that the update completes successfully.
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4878.
Removes the modal dialog alerting users that there's a pre-existing instance of the GUI updater on starting another one, replacing it it with a call to syslog, logging at NOTICE level.
Testing
sudo journalctl -f | grep SecureDropUpdaterpython3 ~/Persistent/securedrop/journalist_gui/SecureDropUpdater- verify that the GUI updater appearspython3 ~/Persistent/securedrop/journalist_gui/SecureDropUpdater- verify that the GUI updater does not appear, and a line "SecureDrop Workstation Updater is already running" is logged in the first terminalDeployment
Deployed when workstations are updated.
Checklist
If you made non-trivial code changes: