Use the same 2FA instructions in journo/admin templates #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The journalist template says "verification code" instead of just "code" in "Once you have paired FreeOTP with this account, enter the 6-digit code below". This makes them consistent and reduces the translation work.
rmol
requested review from
heartsucker,
kushaldas and
redshiftzero
as code owners
|
It should say |
|
@ninavizz Yeah, this ticket is making the admin version of the template also say |
zenmonkeykstop
approved these changes
Dec 4, 2019
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
The journalist template says "verification code" instead of just "code" in "Once you have paired FreeOTP with this account, enter the 6-digit code below". This makes the equivalent admin template consistent and reduces the translation work.
This isn't urgent and can be dealt with after 1.2.0.
Testing
make dev.journalistRESET MOBILE APP CREDENTIALSOnce you have paired FreeOTP with this account, enter the 6-digit verification code below:Adminin the top navigation bar.Editfor one of the accounts.RESET MOBILE APP CREDENTIALSOnce you have paired FreeOTP with this account, enter the 6-digit verification code below:Deployment
Adds a clarifying word to the admin 2FA reset template, making it consistent. Has no effect beyond the user interface.
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made non-trivial code changes: