Clarified Yubikey OTP requirement #5034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
requested review from
emkll,
kushaldas and
redshiftzero
as code owners
eloquence
reviewed
Nov 26, 2019
docs/yubikey_setup.rst
Outdated
| are made by a company called Yubico and are `commercially available`_. | ||
| are made by a company called Yubico and are `commercially available`_. The | ||
| *Journalist Interface* uses a feature called OTP, which is supported by most | ||
| types of Yubikey, but not the blue Security Key series. Before setting up |
There was a problem hiding this comment.
Yubikey->YubiKey (astonishingly, we've been mostly consistent about this)
perhaps Security Key->"Security Key" to make it clearer that it's a product name?
|
Closing without merge - this is covered in #4998 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5033.
Updates key-based 2FA setup docs to link to appropriate page for Yubikey hardware and make it explicit that keys need to support OTP.
Testing
Docs-only change, review for correctness and clarity.
Deployment
Docs-only deployment, will be built if merged into appropriate branches.
Checklist
If you made changes to documentation:
make docs-lint) passed locally