Removes journalist UI modal test xfail. #4987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
requested review from
heartsucker,
kushaldas and
redshiftzero
as code owners
zenmonkeykstop
force-pushed
the
4978-love-me-some-modals
branch
2 times, most recently
from
c39294e to
c6d78ed
Compare
emkll
reviewed
Nov 12, 2019
redshiftzero
suggested changes
Nov 13, 2019
zenmonkeykstop
force-pushed
the
4978-love-me-some-modals
branch
from
118a95b to
680dd63
Compare
redshiftzero
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4978
Adds a function to set TBB security level explicitly, uses it to switch TBB to correct state for journalist functional tests.
Change required because TBB 9.0.1 is being started with Javascript disabled. Rather than getting into managing individual preferences related to browser functionality, it makes sense to simulate user behaviour by toggling the security slider pref to get TBB 9.0.1 into the correct state. (This would also be useful for testing security warnings on the source interface, or any other featurest that rely on specific TBB security levels.)
Testing
test_journalist_interface_ui_with_modal?Deployment
Testing-only.
Checklist