-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turns on verbose docker builds for make dev #4974
Turns on verbose docker builds for make dev #4974
Conversation
make dev
heads up #4973 contains the TBB 9.0.1 change and tests are failing in CI, so we'll need to investigate what's happening there (not sure if anyone's tested to see if they can reproduce the test failure locally) |
@redshiftzero yup looks like an actual SD bug - in 9.0.1, the JI source filter widget isn't showing with default page settings. Taking a look. |
Let's also mark |
Did that, tests pass locally with that change, so let's see what CI thinks (running now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've xfailed one test and skipped two others, but this gets CI back to green to unblock other merges, approving and will open followups for these test updates which we should fix prior to the next release
@zenmonkeykstop or @emkll when you get a chance can you 👍 my changes here? (so I'm not approving my own commits on the end). @zenmonkeykstop's changes otherwise lgtm |
I should note for the reviewer here: this doesn't address the second part of #4972 (comment) regarding supervisord in the dev env, so we'll need to open another followup for that (doing now and will cross-link) |
cf95df0
to
345edc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zenmonkeykstop the docs (the tip in particular) refer users to also set I would propose the following be removed as it is now default behavior: If so, should I open a follow up issue and PR? |
Status
Ready for review
Description of Changes
Fixes #4972 .
Sets an env var,
DOCKER_BUILD_VERBOSE
required to makemake dev
verbose. Also bumpsTBB_VERSION
to 9.0.1, as 8.* versions are no longer available.Testing
Run
make dev
, confirm that the docker build progress is displayed, and that dev container starts.