api: add journalist first name, last name to token response #4971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
requested review from
emkll,
heartsucker,
kushaldas and
zenmonkeykstop
as code owners
rmol
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
Looks good to me. Ran through the test plan in freedomofpress/securedrop-client#605 successfully.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Towards freedomofpress/securedrop-client#575
Changes proposed in this pull request:
Testing
You can follow the steps in securedrop-client PR here to test the server, SDK, and client side changes together: freedomofpress/securedrop-client#605
Deployment
deployed via
securedrop-app-codepackageChecklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locally