Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated keepassx setup instructions to use Tails default location #4970

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #4335.

Updates the instructions for setting up the keepassx database, to use the Tails default location and save the user having to explicitly navigate to and open the correct database every time.

Testing

Docs-only PR, review for clarity and correctness.

Deployment

Deployed by docs build.

Checklist

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@huertanix
Copy link
Member

Not exactly related, but this issue may/may not lead to some changes in Tails creating a default DB in this location when Persistence is activated in the future: https://redmine.tails.boum.org/code/issues/17212.

Comment on lines 172 to 173
cd ~/Persistent
cp securedrop/tails_files/keepassx.kdbx keepassx.kdbx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use absolute paths here instead of cd'ing into the destination?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. It makes the command a bit long, which is why I was initially against it, so it's now split across two lines.

@zenmonkeykstop zenmonkeykstop force-pushed the docs-4335-keepassx-location branch from 839e6b7 to 3a86deb Compare November 6, 2019 17:05
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (ran through this to test the behavior in Tails 4 just now), just one comment inline

docs/set_up_admin_tails.rst Outdated Show resolved Hide resolved
@zenmonkeykstop zenmonkeykstop force-pushed the docs-4335-keepassx-location branch from 3a86deb to decf2c1 Compare November 9, 2019 17:08
@redshiftzero redshiftzero merged commit f1f5cfd into freedomofpress:develop Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename KeePassX template filename to match default KeePassX filename and adjust docs
4 participants