-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated keepassx setup instructions to use Tails default location #4970
updated keepassx setup instructions to use Tails default location #4970
Conversation
Not exactly related, but this issue may/may not lead to some changes in Tails creating a default DB in this location when Persistence is activated in the future: https://redmine.tails.boum.org/code/issues/17212. |
docs/set_up_admin_tails.rst
Outdated
cd ~/Persistent | ||
cp securedrop/tails_files/keepassx.kdbx keepassx.kdbx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use absolute paths here instead of cd'ing into the destination?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. It makes the command a bit long, which is why I was initially against it, so it's now split across two lines.
839e6b7
to
3a86deb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good (ran through this to test the behavior in Tails 4 just now), just one comment inline
3a86deb
to
decf2c1
Compare
Status
Ready for review
Description of Changes
Fixes #4335.
Updates the instructions for setting up the keepassx database, to use the Tails default location and save the user having to explicitly navigate to and open the correct database every time.
Testing
Docs-only PR, review for clarity and correctness.
Deployment
Deployed by docs build.
Checklist
If you made changes to documentation:
make docs-lint
) passed locally