Fix securedrop-admin crash when no operation given under Python 3 #4912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
towards #4910.
Under Python 3, running securedrop-admin with no positional argument results in an ugly error, due to https://bugs.python.org/issue16308.
Under Python 3.7, we could simply add
dest
andrequired
arguments to theadd_subparsers
call, butrequired
isn't available in Python 3.5, so would break under Tails 3.Testing
Run
securedrop/bin/dev-shell bash
to start a shell in the dev container, then run:cd ..
./securedrop-admin setup
./securedrop-admin -v
You should see
Please specify an operation.
followed by thesecuredrop-admin
help.Deployment
This only affects the admin workstation.
Checklist
If you made changes to
securedrop-admin
:make -C admin test
) pass in the admin development containerIf you made non-trivial code changes: