Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for admin password in GUI updater #4877

Merged

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #4387

Adds a check for the administration password when Update Now is clicked in the GUI updater in Tails. If an administration password is set, the update proceeds as normal. If a password is not set, a modal dialog is displayed with an appropriate message, and the Update Now button is disabled.

Testing

  • On an existing install (prod VMs or hardware), start up Tails workstation with PV unlocked. Check out this branch.
  • Reboot Tails with PV unlocked and an admin password not set.
  • verify that the GUI updater appears after Tails connects to the Tor network
  • click Update Now. Verify that the modal warning appears, the Update Now button is disabled, and the update is not triggered.
  • Reboot Tails with PV unlocked and an admin password set
  • verify that the GUI updater appears after Tails connects to the Tor network
  • click Update Now. Verify that the modal does not appear, and that the update is triggered.

Deployment

Deployed with initial install or workstation code update.

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

@zenmonkeykstop zenmonkeykstop force-pushed the 4387-gui-updater-needs-password branch from f4ee428 to 4c315a3 Compare September 27, 2019 18:56
@eloquence eloquence changed the title added check for admin password in GUI updater Added check for admin password in GUI updater Sep 28, 2019
@eloquence
Copy link
Member

eloquence commented Sep 28, 2019

Works as expected, tested with a patched 0.14.0 tag and a patched develop, on Tails 3.16 series prod Admin Workstation.

  • Modal comes up when admin password is not set.
  • Modal does not come up when admin password is set.
  • "Update now" button is greyed out when expected, and is not clickable.
  • "Update now" button is active when expected, and is clickable.
  • Updates work as expected.

GUI code should be reviewed by someone familiar w/ that codebase but I think if any additional pre-QA interactive testing is required here, it should be on Tails 4.

I did encounter #4878 which I don't think is a regression; I've seen that in prod before. I will try to do another clean repro on that.

@zenmonkeykstop zenmonkeykstop force-pushed the 4387-gui-updater-needs-password branch from 4c315a3 to 4433d6b Compare October 7, 2019 17:17
@emkll emkll mentioned this pull request Oct 7, 2019
13 tasks
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Tails VM 3.16, test plan and visual review looks good to me:

  • Reboot Tails with PV unlocked and an admin password not set.
  • verify that the GUI updater appears after Tails connects to the Tor network
  • click Update Now. Verify that the modal warning appears, the Update Now button is disabled, and the update is not triggered.
  • Reboot Tails with PV unlocked and an admin password set
  • verify that the GUI updater appears after Tails connects to the Tor network
  • click Update Now. Verify that the modal does not appear, and that the update is triggered.

@emkll emkll merged commit 24e24e7 into freedomofpress:develop Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphical updater re-appears, fails after initial run without admin password
3 participants