Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stronger warning against using manage.py reset #4850

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

eloquence
Copy link
Member

Status

Ready for review

Description of Changes

Related to #4839

Testing

Verify that command output looks good to you.

@codecov-io
Copy link

Codecov Report

Merging #4850 into develop will increase coverage by 4.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4850      +/-   ##
===========================================
+ Coverage    77.53%   81.74%   +4.21%     
===========================================
  Files           49       49              
  Lines         3418     3418              
  Branches       392      392              
===========================================
+ Hits          2650     2794     +144     
+ Misses         669      533     -136     
+ Partials        99       91       -8
Impacted Files Coverage Δ
securedrop/securedrop/manage.py 76.89% <0%> (ø) ⬆️
securedrop/securedrop/journalist_app/admin.py 86.2% <0%> (+1.14%) ⬆️
securedrop/securedrop/journalist_app/utils.py 89% <0%> (+4.71%) ⬆️
securedrop/securedrop/models.py 90.6% <0%> (+5.8%) ⬆️
securedrop/securedrop/journalist_app/main.py 75.49% <0%> (+6.86%) ⬆️
securedrop/securedrop/journalist_app/account.py 93.87% <0%> (+12.24%) ⬆️
securedrop/securedrop/journalist_app/col.py 83.67% <0%> (+16.32%) ⬆️
securedrop/securedrop/store.py 93.79% <0%> (+26.2%) ⬆️
securedrop/securedrop/rm.py 95.23% <0%> (+42.85%) ⬆️
securedrop/securedrop/worker.py 85% <0%> (+58.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a61b7e...63245c3. Read the comment docs.

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./manage.py help output looks good. No change anywhere else.

@zenmonkeykstop zenmonkeykstop merged commit daebfed into develop Sep 23, 2019
@legoktm legoktm deleted the danger-is-not-enough branch January 9, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants