Default v3_onion_services to off in validate_tails_environment.yml #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lack of this variable has tripped us up in several roles, and depending on how the validate role is used, adding it to defaults/main.yml within that role might not fix it, so let's add a fact in the validate_tails_environment playbook defaulting it to off.
rmol
requested review from
conorsch,
emkll,
kushaldas and
msheiny
as code owners
kushaldas
approved these changes
Sep 10, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
The lack of this variable has tripped us up in several roles, and depending on how the validate role is used, adding it to defaults/main.yml within that role might not fix it, so let's add a fact in the
validate_tails_environment.ymlplaybook defaulting it to off.Fixes #4774.
Testing
Follow the 1.0.0 test plan through to
Tor onion services: upgrade to v2 QA. You should get no error fromsecuredrop-admin install.Deployment
This should improve the reliability of
securedrop-admin installwhen run on an existing admin workstation with aninstall_files/ansible-base/group_vars/all/site-specificthat does not contain the new onion service variables.Checklist
If you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made non-trivial code changes: