Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4762 adds missing variables for tailsconfig #4765

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

kushaldas
Copy link
Contributor

Status

Ready for review

Adds the missing variables for tailsconfig when sdconfig was not run.

Fixes #4762

Testing

Make sure that following two variables are not present in the install_files/ansible-role/group_vars/all/site-specific file.

v2_onion_services
v3_onion_services

Then execute ./securedrop-admin tailsconfig command.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make -C securedrop test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@codecov-io
Copy link

Codecov Report

Merging #4765 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4765   +/-   ##
========================================
  Coverage    81.74%   81.74%           
========================================
  Files           49       49           
  Lines         3418     3418           
  Branches       392      392           
========================================
  Hits          2794     2794           
  Misses         533      533           
  Partials        91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd64fa...dd174f8. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #4765 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4765   +/-   ##
========================================
  Coverage    81.74%   81.74%           
========================================
  Files           49       49           
  Lines         3418     3418           
  Branches       392      392           
========================================
  Hits          2794     2794           
  Misses         533      533           
  Partials        91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd64fa...dd174f8. Read the comment docs.

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redshiftzero redshiftzero merged commit 01fbef7 into develop Sep 9, 2019
@redshiftzero redshiftzero deleted the oh_my_missing_variables branch September 9, 2019 13:21
kushaldas added a commit that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"securedrop-admin tailsconfig" fails after updating admin workstation checkout from 0.14.0 to 1.0.0~rc2
3 participants