Bumps tor version 0.3.5.8 -> 0.4.0.5 #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the fetch-tor-packages logic to pull in current stable LTS [0] versions of Tor. The prior 0.3.x versions are no longer available from upstream tor repo, so they cannot be fetched. Includes updates to test vars, as well. [0] https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases
|
@conorsch I just now approved the PR for the git LFS repository, and then sadly figured out that I don't have merge rights in that repository. |
Fixed! Please try again, @kushaldas. |
|
@conorsch worked :) Now I will wait for 15 minutes and then restart the CI job. |
Codecov Report
@@ Coverage Diff @@
## develop #4661 +/- ##
========================================
Coverage 82.67% 82.67%
========================================
Files 45 45
Lines 3122 3122
Branches 338 338
========================================
Hits 2581 2581
Misses 454 454
Partials 87 87Continue to review full report at Codecov.
|
|
Kicking the Python2 app tests. |
kushaldas
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
- Review the tor release schedule (above) and confirm 0.4.0.x is the series we want to target
- Review and merge Adds tor 0.4.0.5 deb packages securedrop-apt-test#9
- Confirm 0.4.0.5 packages are available in https://apt-test.freedom.press/pool/main/t/tor/ (takes ~15m)
- Restart CI on this PR (so the new tor packages are used)
- Spin up staging VMs, confirm running tor 0.4.05
- Confirm Source & Journalist Interface working well over Onion URLs
Finally the CI is green. Approved 🌈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Description of Changes
Fixes #4658.
Changes proposed in this pull request:
Updates the fetch-tor-packages logic to pull in current stable LTS [0]
versions of Tor. The prior 0.3.x versions are no longer available from
upstream tor repo, so they cannot be fetched.
Includes updates to test vars, as well.
[0] https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases
Testing
We should also confirm that tor-over-ssh works fine on 0.4.x, but that can wait until dedicated QA period.
Deployment
Yes, significant version change to tor. Must be tested thoroughly prior to release of SD 1.0.0.
Checklist
If you made changes to the server application code:
make lint) and tests (make -C securedrop test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locally