Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grsecurity kernels to 4.4.182 #4543

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Update grsecurity kernels to 4.4.182 #4543

merged 2 commits into from
Jun 20, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Jun 19, 2019

Status

Ready for review

Description of Changes

Fixes #4520, #3663 .

Bumps kernels to 4.4.182
Adds intel-microcode to list of dependencies

Testing

Testing can only be done once kernels are upgraded to apt test.

Clean install

  • completes without error
  • uname -r returns 4.4.182-grsec on app and mon servers

Upgrade testing

  • check out this branch
  • change molecule/shared/stable-ver to 0.13.0 (because 0.13.1 boxes not yet uploaded, see Release SecureDrop 0.13.1 #4524 )
  • make upgrade-start
  • On app and mon, change security.list apt.freedom.press -> apt-test.freedom.press and `sudo cron-apt -i -s
  • Cron-apt completes without error on app and mon servers
  • Reboot app and mon
  • uname -r returns 4.4.182-grsec on app and mon servers
  • intel-microcode package is installed on app and mon servers

Deployment

Both new and existing installs will be updated via unattended apt updates.

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

emkll added 2 commits June 19, 2019 17:27
Bumps kernel version in metapackage. This kernel version addresses network stack vulnerabilities known as SACK panic (https://access.redhat.com/security/vulnerabilities/tcpsack):

* CVE-2019-11479
* CVE-2019-11478
* CVE-2019-11477
This will ensure the lastest CPU microcode is used to provide further mitigations against CPU vulnerabilities:

* CVE-2017-5753 (Spectre v1)
* CVE-2017-5715 (Spectre v2)
* CVE-2017-5754 (Spectre v3 a.k.a. Meltdown)
* CVE-2018-3640 (Spectre v3a)
* CVE-2018-3639 (Spectre v4)
* CVE-2018-3615 (Foreshadow SGX a.k.a. L1TF)
* CVE-2018-3620 (Forshadow-NG OS a.k.a. L1TF)
* CVE-2018-3646 (Foreshadow-NG VMM a.k.a L1TF)
* CVE-2018-12126 (Fallout)
* CVE-2018-12130 (ZombieLoad)
* CVE-2018-12127 (RIDL a.k.a. MLPDS)
* CVE-2019-11091 (RIDL a.k.a MDS)

While an attacker would need code execution to be able to exploit these vulnerabilities, updating the CPU microcode will provide defense-in-depth.
@emkll emkll marked this pull request as ready for review June 20, 2019 13:57
@emkll emkll requested a review from zenmonkeykstop June 20, 2019 13:57
@zenmonkeykstop
Copy link
Contributor

zenmonkeykstop commented Jun 20, 2019

Tested clean install on Mac Minis:

  • completes without error
  • uname -r returns 4.4.182-grsec on app and mon servers

Upgrade testing:

  • Cron-apt completes without error on app and mon servers
  • Reboot app and mon:
    • uname -r returns 4.4.182-grsec on app and mon servers
    • intel-microcode package is installed on app and mon servers

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emkll
Copy link
Contributor Author

emkll commented Jun 20, 2019

Thanks @zenmonkeykstop for the review! I'm going to merge this to unblock CI, as other PR's will need to be re-based on this in order to pass infra tests. We will do further QA as part of 0.14.0 release testing.

@emkll emkll merged commit dc648e9 into develop Jun 20, 2019
@emkll emkll deleted the bump-kernels-to-4.4.182 branch June 20, 2019 21:41
@zenmonkeykstop zenmonkeykstop mentioned this pull request Jun 27, 2019
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SecureDrop kernels to 4.4.181+
2 participants