Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 0.13.1 changelog to develop #4537

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Backport 0.13.1 changelog to develop #4537

merged 2 commits into from
Jun 19, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Jun 19, 2019

Status

Ready for review

Description of Changes

Towards #4524

Testing

  • All 0.13.1 commits have been backported
  • Changelog / strings are accurate

@redshiftzero redshiftzero mentioned this pull request Jun 19, 2019
Closed
12 tasks
@redshiftzero
Copy link
Contributor

lint failure here due to #4540

@redshiftzero
Copy link
Contributor

We'll need to append a fix for #4540 to #4539 and then rebase this as I'm pretty sure that the test jobs will fail due to #4538 even if we get the lint job passing

emkll added 2 commits June 19, 2019 14:56
@emkll
SecureDrop 0.13.1-rc1
c8c8fb1 
(cherry picked from commit 389e505)
@emkll
SecureDrop 0.13.1
2e551f6 
(cherry picked from commit 1f72337)
@emkll emkll force-pushed the 0.13.1-to-develop branch from 3e712a1 to 2e551f6 Compare June 19, 2019 18:56
@emkll
Copy link
Contributor Author

emkll commented Jun 19, 2019

Rebased on latest develop which should resolve linting issues.

@codecov-io
Copy link

codecov-io commented Jun 19, 2019 •
edited
Loading

Codecov Report

Merging #4537 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4537   +/-   ##
========================================
  Coverage    82.53%   82.53%           
========================================
  Files           45       45           
  Lines         3121     3121           
  Branches       339      339           
========================================
  Hits          2576     2576           
  Misses         458      458           
  Partials        87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5027d1a...2e551f6. Read the comment docs.

redshiftzero
redshiftzero approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redshiftzero redshiftzero merged commit e23e48e into develop Jun 19, 2019
@redshiftzero redshiftzero deleted the 0.13.1-to-develop branch June 19, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redshiftzero redshiftzero redshiftzero approved these changes

@conorsch conorsch Awaiting requested review from conorsch

@kushaldas kushaldas Awaiting requested review from kushaldas

@msheiny msheiny Awaiting requested review from msheiny

@zenmonkeykstop zenmonkeykstop Awaiting requested review from zenmonkeykstop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emkll @redshiftzero @codecov-io