Update Internationalization docs and add translator list function to i18n_tool.py #4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of six.u was corrupting translator names. According to https://pythonhosted.org/six/index.html#six.u -- "On Python 2, u() doesn't know what the encoding of the literal is. Each byte is converted directly to the unicode codepoint of the same value. Because of this, it's only safe to use u() with strings of ASCII data." Of course some translators' names were not just ASCII, so I've replaced usage of six.u with u"", as it should be safe on both Python 2 and Python 3 > 3.3, per PEP-0414. I also changed the commit format to put each contributor's name on its own line, and tried to clarify the source of the translations. It was confusing to me, at least, that translations were being "copied from" a revision that involved a different language. Finally, we were gathering the list of contributors from commits other than just the Weblate contributions, so whoever last ran the tool was getting credited for translations since. I've changed the tool to only look for contributors in the automated Weblate commits.
rmol
requested review from
emkll,
heartsucker,
kushaldas,
redshiftzero and
zenmonkeykstop
as code owners
|
(Since this includes code changes to the tool, should the branch have the The flake8 fail appears to be real: |
eloquence
changed the title
|
Shoot, didn't think about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Restructured the Internationalization docs (
docs/development/i18n.rst) to make the order of operations clearer for developers and localization managers. Updated the process now that string and feature freeze are synchronized.Added a
list-translatorsfunction toi18n_tool.pyto simplify translator attribution at release time.Fixes #4441.
Testing
Run
make docs, navigate to http://localhost:8000/development/i18n.html and read critically.Test the
i18n_tools.pychanges withmake -C securedrop list-translatorsandmake -C securedrop list-all-translators.Deployment
This is pretty much dev-only and shouldn't affect deployment, as the changes to
i18n_tool.pydidn't involve compilation.Checklist
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locally