Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Issue 4454 #4462

Merged
merged 3 commits into from
May 25, 2019
Merged

Resolve Issue 4454 #4462

merged 3 commits into from
May 25, 2019

Conversation

drewmassey
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #4454 .

Changes proposed in this pull request:

Testing

How should the reviewer test this PR?

  • Spin up local environment
  • Confirm that "learn how to set it safest" warning that comes up as described in the issue is on the right, not left side of the screen.

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.
    As mentioned in the Issue thread, this does not try to tell the difference between Tor 8.5 and before.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make -C securedrop test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update source interface instructions for Tor Browser 8.5
2 participants