added Greek and Arabic supported locales in staging #4419
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
requested review from
conorsch,
emkll,
kushaldas and
msheiny
as code owners
zenmonkeykstop
force-pushed
the
4418-add-locales-in-staging
branch
from
c86a133 to
fe17c56
Compare
redshiftzero
reviewed
May 9, 2019
| @@ -36,14 +36,16 @@ def test_securedrop_application_apt_dependencies(host, package): | |||
|
|
|||
| def test_securedrop_application_test_locale(host): | |||
| """ | |||
| Ensure SecureDrop DEFAULT_LOCALE is present. | |||
| Ensure both SecureDrop DEFAULT_LOCALE and SUPPORTED_LOCALES are present.` | |||
There was a problem hiding this comment.
Nit: trailing ` at end of line
zenmonkeykstop
force-pushed
the
4418-add-locales-in-staging
branch
from
fe17c56 to
e51f745
Compare
redshiftzero
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4418.
Adds Greek and Arabic as supported locales in staging environment, to simplify verification of locale-specific features and layouts.
Testing
molecule verify -s {container}-stagingand verify that the locale tests still pass.Deployment
Staging-only change.
Checklist
If you made changes to the system configuration:
qubes-stagingscenario) that will be fixed separately. **If you made non-trivial code changes: