Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 0.12.2 changelog. #4389

Merged
merged 3 commits into from
Apr 26, 2019

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Apr 26, 2019

Status

Ready for review

Description of Changes

Add 0.12.2 changes to changelog.

Toward #4338.


### Operations

* SecureDrop grsec kernels have been updated to 4.4.177 and provide support for Intel e1000e series NICs (#4308)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inaccurate - the kernel already had an e1000e module. The changes were to provide support for the chipsets used in 7-series Intel NUCs.

Copy link
Contributor

@emkll emkll Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! unfortunately that changelog has been released as part of 0.12.2, so I don't think we should go retroactively modify it.

I've tried wording the changelog based on the description provided in freedomofpress/ansible-role-grsecurity-build#46 (comment) . I agree, it could be more clear, and it may have been better to state that patches were applied applied to the 4.4.177 source.

@rmol rmol changed the title Backport 0.12.2 changelog. [WIP] Backport 0.12.2 changelog. Apr 26, 2019
@rmol rmol force-pushed the backport-0.12.2-changelog branch from f012f1e to ca0745e Compare April 26, 2019 16:49
emkll added 3 commits April 26, 2019 13:23
(cherry picked from commit 4154adc)
(cherry picked from commit 5018821)
(cherry picked from commit 138d67f)
@rmol rmol force-pushed the backport-0.12.2-changelog branch from ca0745e to 78ec090 Compare April 26, 2019 17:31
@rmol rmol changed the title [WIP] Backport 0.12.2 changelog. Backport 0.12.2 changelog. Apr 26, 2019
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmol , this looks good to merge once CI passes.

@emkll emkll mentioned this pull request Apr 26, 2019
16 tasks
@codecov-io
Copy link

Codecov Report

Merging #4389 into develop will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #4389      +/-   ##
==========================================
- Coverage    83.97%   83.9%   -0.07%     
==========================================
  Files           45      45              
  Lines         2921    2921              
  Branches       319     319              
==========================================
- Hits          2453    2451       -2     
- Misses         393     394       +1     
- Partials        75      76       +1
Impacted Files Coverage Δ
securedrop/securedrop/crypto_util.py 90.4% <0%> (-1.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7cbe7e...78ec090. Read the comment docs.

@emkll emkll merged commit 1a87e0f into freedomofpress:develop Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants