Fix Dockerfiles, create-dev-data #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Dockerfiles, running apt-install in a separate RUN after apt-update could fail if the output of the apt-update's RUN were cached; apt-install could be looking for outdated versions of packages. In create-dev-data, fix a misplaced print/format parenthesis.
rmol
requested review from
heartsucker,
kushaldas and
redshiftzero
as code owners
|
I was seeing this error before and no longer see it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
In the Dockerfiles, running
apt-installin a separateRUNafterapt-updatecould fail if the output of theapt-update'sRUNwere cached;apt-installcould be looking for outdated versions of packages.In
create-dev-data.py, fix a misplaced print/format parenthesis.Testing
Run
make -C securedrop devto build and run the Python 2 container.Run
PYTHON_VERSION=3 make -C securedrop devto build and run the Python 3 container.Both should get through image building/updating and end up running the SD services.
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development containerIf you made non-trivial code changes: