-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump SecureDrop kernel to 4.4.177 #4308
Conversation
These kernels now offer support for Intel e1000e NICs.
This should now be ready for review. CI will staging-test-with-rebase will fail on all PRs due to 4.4.177 currently being served by apt-test, and the tests are checking for 4.4.167 |
@zenmonkeykstop @emkll Hate to end the week with bad news, but it's probably just something I've done wrong. I tried a fresh install of SD on Xenial, by changing the apt repo to apt-test in my develop checkout and running I logged in on their consoles to find they're both now running the 4.4.177-grsec kernel, but with no Ethernet interfaces configured. Running These are NUC 7i5BNHs. One has the same BIOS revision as above, 72, while the other is at 76. The NICs worked fine for the first part of the installation. |
Hi @rmol - if the kernel version bumped, I don't think that you did anything wrong. Could you do me a favour and run |
@zenmonkeykstop There is not. |
Summarizing discussion from today's standup: @rmol's surprising result of broken hardware support was caused by a mix-up on the backend, with the We'll proceed with manual QA on hardware prior to the 0.12.2 point release. Approving and merging, given that the changes are presented are behaving well (as evidenced by CI), and also because the new test vars are required for other PRs to pass CI now, given the automatic rebase in CI. At a later date, let's consider a branch naming pragma with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on visual review, and confirmation that CI is passing with the new test vars.
thanks for the review @rmol I have updated apt-test with kernels that should now be e1000e compatible. The previous kernels were built on master instead of the e1000e feature branch, as I was using a disposable VM and forgot to explicitly check out the correct WIP remote branch, my apologies. |
Status
Ready for review
Description of Changes
Towards #4024
Simply bumps strings for grsec kernel, the kernel work was done by @zenmonkeykstop in freedomofpress/ansible-role-grsecurity-build#46
Changes proposed in this pull request:
Test Plan
First:
To validate the functionality of these kernels:
Deployment
New and existing installs will be upgraded via apt
Checklist
If you made non-trivial code changes: