Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builder images #4281

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Update builder images #4281

merged 1 commit into from
Mar 20, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Mar 20, 2019 •
edited by conorsch
Loading

Status

Ready for review

Description of Changes

Towards #4260

Testing

  • make build-debs completes without error
  • make build-debs trusty completes without error

Deployment

Dev only

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

@emkll
Update builder images
667abe1 
Builder images needed security updates
@emkll emkll added this to the 0.12.1 milestone Mar 20, 2019
@conorsch
Copy link
Contributor

Reviewing now. Kicking off local builds, will report back.

conorsch
conorsch approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed passing builds locally. 😎

@conorsch conorsch merged commit 3ddd548 into develop Mar 20, 2019
@conorsch conorsch deleted the update_builder_20190320 branch March 20, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

@kushaldas kushaldas Awaiting requested review from kushaldas

@msheiny msheiny Awaiting requested review from msheiny

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

@zenmonkeykstop zenmonkeykstop Awaiting requested review from zenmonkeykstop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@emkll @conorsch