Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Make it clearer that key generation must be done on the SVS #4249

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

eloquence
Copy link
Member

Resolves #4076

Status

Ready for review

Checklist

  • Doc linting (make docs-lint) passed locally

@eloquence
Copy link
Member Author

eloquence commented Mar 8, 2019

FWIW, I debated with myself on whether an "important" banner is warranted, then decided in favor of it; I felt that this document was a good opportunity to begin reinforcing the idea that the private key is especially sensitive and that its generation warrants additional attention.

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the final HTML, also this is an important point. Thank you. 👍

@kushaldas kushaldas merged commit afcf563 into develop Mar 8, 2019
@kushaldas kushaldas deleted the docs-clarify-airgap-keygen branch March 8, 2019 09:32
@eloquence eloquence mentioned this pull request Mar 14, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants