Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cssmin dependency #4227

Merged
merged 1 commit into from
Mar 5, 2019
Merged

remove cssmin dependency #4227

merged 1 commit into from
Mar 5, 2019

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Mar 5, 2019

Status

Ready for review

/cc @rmol

Test Plan

  • make clean
  • make build-debs
  • make staging
  • Verify that CSS is delivered from staging instances by checking that the UI looks as expected
  • Verify that CSS is minified by Sass by comparing file sizes

Description of Changes

Fixes #2808

We can remove our cssmin dependency because we already use a ruby script that we tell to compress our css files at debian packaging time.

Changes proposed in this pull request:

  • Remove cssmin dependency from requirements.txt and requirements.in

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@heartsucker heartsucker merged commit 21fcf15 into freedomofpress:develop Mar 5, 2019
@sssoleileraaa sssoleileraaa deleted the remove-cssmin branch March 5, 2019 23:14
@redshiftzero redshiftzero added this to the 0.13.0 milestone May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find and migrate to maintained alternative to cssmin
3 participants