Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused wireless packages #4223

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Mar 4, 2019

Status

Ready for review

Description of Changes

Fixes #4163

Testing

Clean install scenario:

  • Xenial staging tests pass
  • Nightly Trusty tests pass

Upgrade testing scenario (requires prod VMs or hardware)

  • Install on 0.12.0 (on 0.12.0 tag)
  • Upgrade to Xenial
  • Run install on this branch
  • Observe wireless packages are removed

Deployment

This change to the Ansible logic will be deployed via GitHub, and deployed to server when an admin installs.

Checklist

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Wireless-related packages are not required for SecureDrop App and Mon servers. `gcc` and dpkg-dev` however are required, as they are listed dependencies for `libgcc1`, a dependency for very large number of packages including `apt`. These packages are installed by default in Trusty, and will remain if an instance is upgraded to Xenial.
@conorsch
Copy link
Contributor

conorsch commented Mar 7, 2019

Performed manual testing of the upgrade scenario. For the staging test plan, I'm relying on CI to confirm working, after visual review of the logic.

Clean install scenario:

Upgrade testing scenario (requires prod VMs or hardware)

  • Install on 0.12.0 (on 0.12.0 tag)
  • Upgrade to Xenial
  • Run install on this branch
  • Observe wireless packages are removed

During prod VM testing, after installing from 0.12.0, I upgraded only app-prod to 16.04, then re-ran the install action on this feature branch. During the install run, confirmed that Ansible reported the package removal on both hosts, regardless of Trusty or Xenial. Additionally, confirmed via interactive login that the three (3) packages were not installed on both hosts.

@conorsch conorsch merged commit 626182e into develop Mar 7, 2019
@conorsch conorsch deleted the 4163-remove-unnecessary-packages branch March 7, 2019 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants