Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] some updates for making Xenial default env #4213

Merged
merged 2 commits into from
Mar 5, 2019

Conversation

redshiftzero
Copy link
Contributor

Status

Ready for review

Description of Changes

Two more checkboxes in #4155, an easy merge

Testing

  • Check I got all the application-level references to the make test* targets in the application level makefile
  • Check I got all the 14.04 references in the Vagrantfile

Deployment

None, we're recommending Xenial in prod already

heartsucker
heartsucker previously approved these changes Feb 28, 2019
As of SecureDrop 0.12.0, Xenial is the default environment for
SecureDrop servers. Trusty will soon be deprecated.
@emkll
Copy link
Contributor

emkll commented Mar 4, 2019

Running into some issues running make test locally, there appears to be a problem building the Docker image:

Processing triggers for dbus (1.10.6-1ubuntu3.3) ...
Errors were encountered while processing:
 libglib2.0-cil
 libglib2.0-cil-dev
 libgtk2.0-cil
 libgtk2.0-cil-dev
E: Sub-process /usr/bin/dpkg returned an error code (1)
The command '/bin/sh -c apt-get update &&     apt-get install -y devscripts                        python-pip libpython2.7-dev libssl-dev secure-delete                        gnupg2 ruby redis-server firefox git xvfb haveged curl                        gettext paxctl x11vnc enchant libffi-dev sqlite3 gettext sudo                        libgtk2.0' returned a non-zero code: 100
Makefile:21: recipe for target 'test' failed
make: *** [test] Error 1

Is anyone else seeing this?

@eloquence
Copy link
Member

eloquence commented Mar 5, 2019

Can't reproduce locally with make test, output for me appears identical to the one in CircleCI (including the warning).

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I guess we will update the docs in a separate PR.

docs/development/virtual_environments.rst is the file requires more work.

@heartsucker
Copy link
Contributor

I blew away my docker cache and cannot reproduce this error. I'm going to merge, but if this persists, we should open a follow up.

@heartsucker heartsucker merged commit 1d1a660 into develop Mar 5, 2019
@heartsucker heartsucker deleted the xenial-is-default-dev branch March 5, 2019 09:55
@emkll
Copy link
Contributor

emkll commented Mar 5, 2019

Thanks @heartsucker . For those experiencing these issues, docker system prune -a does indeed resolve the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants