[i18n] add romanian and icelandic, update i18n_tool.py #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstrip removes an extra o from `ro.po` file name, so, we should only remove the last 3 characters.
emkll
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Went through the test plan above, looks good to me:
$ securedrop/bin/dev-shell ./i18n_tool.py --verbose translate-desktop --compile
Run with DOCKER_BUILD_VERBOSE=true for more information
Docker image build in progress done !
2019-02-25 23:49:10,340 INFO <Command u'/usr/bin/msgfmt --desktop --template desktop-journalist-icon.j2.in -o desktop-journalist-icon.j2 -d .'>: starting process
2019-02-25 23:49:10,360 INFO <Command u'/usr/bin/msgfmt --desktop --template desktop-journalist-icon.j2.in -o desktop-journalist-icon.j2 -d .', pid 8>: process started
2019-02-25 23:49:11,570 INFO <Command u'/usr/bin/msgfmt --desktop --template desktop-journalist-icon.j2.in -o desktop-journalist-icon.j2 -d .', pid 8>: process completed
2019-02-25 23:49:11,571 INFO <Command u'/usr/bin/msgfmt --desktop --template desktop-source-icon.j2.in -o desktop-source-icon.j2 -d .'>: starting process
2019-02-25 23:49:11,578 INFO <Command u'/usr/bin/msgfmt --desktop --template desktop-source-icon.j2.in -o desktop-source-icon.j2 -d .', pid 12>: process started
2019-02-25 23:49:12,779 INFO <Command u'/usr/bin/msgfmt --desktop --template desktop-source-icon.j2.in -o desktop-source-icon.j2 -d .', pid 12>: process completed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4192, add icelandic and romanian, supercedes #4186
Testing
Deployment
For translation workflow only
Checklist
If you made non-trivial code changes: