Import okay #4151
Merged
Import okay #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--batch flag helps to import the gpg keys into gpg2 format without having the passphrase.
Codecov Report
@@ Coverage Diff @@
## develop #4151 +/- ##
========================================
Coverage 84.78% 84.78%
========================================
Files 43 43
Lines 2780 2780
Branches 303 303
========================================
Hits 2357 2357
Misses 355 355
Partials 68 68Continue to review full report at Codecov.
|
emkll
approved these changes
Feb 18, 2019
There was a problem hiding this comment.
Followed test plan, no errors in source-error.log !
- Provision prod VMs on 0.12.0-rc1
- Submit a document as a source
- Upgrade (app server) to xenial via
sudo do-release-upgrade(some nice steps thanks to @zenmonkeykstop here) - installed securedrop-app-code package from this branch
- Submit another document as a source
- Ensure no gpg-related errors appear in /var/log/apache2/source-error.log
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4108 .
Changes proposed in this pull request:
Testing
sudo do-release-upgrade(some nice steps thanks to @zenmonkeykstop here)make build-debs-xenialapp-stagingand install it (you have to installpaxctldpackage before)Deployment
Any special considerations for deployment? Consider both:
This should cause no errors in existing production instances.
Checklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locally