Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xenial] fix 2FA unit tests #4069

Merged
merged 2 commits into from
Jan 25, 2019
Merged

[xenial] fix 2FA unit tests #4069

merged 2 commits into from
Jan 25, 2019

Conversation

redshiftzero
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #4037

Changes proposed in this pull request:

  • Runs teardown if there's an issue with the driver setup (a common issue during functional test setup)
  • Also re-uses the hardening fixture in the 2FA app tests, separated into another commit for ease of review
  • See my comment here for more details on the underlying issue.

Testing

  • CI trusty test job should pass
  • 2FA tests should pass in CI xenial test job

Deployment

This touches test only code.

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

@heartsucker heartsucker merged commit 08dde48 into develop Jan 25, 2019
@heartsucker heartsucker deleted the ci-xenial-2fa-test branch January 25, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[xenial] fix 2FA functionality in app code
2 participants