ci: Add app test job using xenial #4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As evidenced by the test failures we've discovered, we'll need to make some changes that ideally work under both Trusty and Xenial. This means that we need to run the application tests in both environments. This PR adds a $BASE_OS env var that can be either "trusty" or "xenial". It uses this env var for docker builds, and modifies the docker build logic to point to a Dockerfile outside of the build context [1]. We make a new directory in the securedrop/ directory called Dockerfiles that contains the Dockerfiles for both environments. By default, the other Makefile targets will use Trusty. Once trusty is EOL, we can delete the Trusty Dockerfile, though it would be prudent to leave the BASE_OS logic in place for the next major OS transition. [1] docker/cli#886
redshiftzero
force-pushed
the
xenial-pgp-journalist
branch
from
ca9a9a1 to
d927f18
Compare
heartsucker
approved these changes
Jan 16, 2019
|
OK after discussion in standup, we're going to indeed merge this CI job and then fix the test failures iteratively (cc @kushaldas @emkll), thanks for review @heartsucker! For the future, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Progress towards #4013, if there are no issues with the below then I will file followup issues for each class of app test failure
As mentioned in #4013, that bug was one of several issues that are surfaced by running the application test suite on Ubuntu Xenial.
In the next couple of weeks we are planning to make a lot of changes here in SecureDrop core to ensure that SecureDrop works as expected for Xenial. To support faster iterations and multiple developers to help out with this effort, I'm proposing in this PR that we add a CI job that runs the Xenial app tests on develop (in addition to the CI job that runs the Trusty app tests). This job is expected to fail until all app issues are resolved.
Why? Because this will be far, far faster than:
Thoughts?
Testing
Are there now two CI jobs running here:
xenial-app-testsandtrusty-app-tests, where trusty passes but xenial does not?Can you now
make test-xeniallocally and run tests, that will fail?Deployment
This is CI and dev env only
Checklist
If you made non-trivial code changes: