avoid accidentally exporting all pub keys #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
suggested changes
Jan 2, 2019
a feature of the `python-gnupg` `list_keys` function of that passing in `None` will return all keys. if we don't have a key for a source and we export their key, we would accidentally export all pubkeys in the key ring. this fixes that.
heartsucker
force-pushed
the
fix-source-key-export
branch
from
2c676ae to
7109aff
Compare
heartsucker
changed the title
redshiftzero
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4005
Avoids exporting all keys when a fingerprint is
None.Testing
Checklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development container