Updating weblate reference codes. #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultimatecoder
requested review from
heartsucker and
redshiftzero
as code owners
ultimatecoder
force-pushed
the
develop-fix-broken-i18n-docs
branch
from
edec77c to
d3ab065
Compare
ultimatecoder
changed the title
kushaldas
suggested changes
Nov 19, 2018
ultimatecoder
force-pushed
the
develop-fix-broken-i18n-docs
branch
2 times, most recently
from
cca931e to
afc08dc
Compare
|
@kushaldas Thanks for reviewing this. I have updated the files according to your comment. I am apologized if I have increased troubles. Have a great day! |
kushaldas
reviewed
Nov 20, 2018
securedrop/i18n_tool.py
Outdated
| @@ -26,7 +26,7 @@ class I18NTool(object): | |||
| # | |||
| # The database of support language, indexed by the language code | |||
| # used by weblate (i.e. whatever shows as CODE in | |||
| # https://weblate.securedrop.club/projects/securedrop/securedrop/CODE/ | |||
| # https://github.com/freedomofpress/securedrop-i18n/tree/i18n/securedrop/translations | |||
There was a problem hiding this comment.
Just change the .club URL to the .org URL here.
kushaldas
suggested changes
Nov 20, 2018
|
Also do not say that this fixes #3929, we sill have to change other things on top of this. You can remove that line from the comment and say this is a partial fix. |
Partialy solves: freedomofpress#3929
ultimatecoder
force-pushed
the
develop-fix-broken-i18n-docs
branch
from
afc08dc to
83c930c
Compare
|
@kushaldas I have updated the PR description and the code according to your comments. Please review them again. Thanks! |
kushaldas
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs to account for Weblate
Status
Completed
Description of Changes
Partially fixes #3929
Testing
Checklist
If you made changes to documentation:
make docs-lint) passed locally