Fix unauthorized message deletion #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug where an authenticated source A could delete the replies send to source B if they could guess the filename. Since we don't throttle source interactions, and since the wordlists are public, an attack could attempt to enumerate them.
1 task
emkll
approved these changes
Oct 22, 2018
There was a problem hiding this comment.
Great find @heartsucker, thanks for the fix! Reproduced the bug and confirm the fixes solves the issue for me. Good to merge once CI passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #3892
Fixes a bug where a source X could delete a reply from a journalist to source Y by guessing the ID.
Testing
See original ticket for the full description of the bug and manual steps to reproduce. There is a regression test for this so
make testwill cover this issue.Deployment
This will not affect deployment.
Checklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development container