Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qa loader #3863

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Fix qa loader #3863

merged 2 commits into from
Nov 29, 2018

Conversation

heartsucker
Copy link
Contributor

@heartsucker heartsucker commented Oct 10, 2018

Status

Ready for review

Description of Changes

Fixes #3739

Alter the loader to not start at the index 1 when creating/altering entities. This prevents mangling existing conversations or users.

Testing

  • start dev container
  • have a conversation with yourself
  • docker exec -it $container ./qa_loader.py -m 1
  • look at conversation, see no strange messages

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as advertised!

@redshiftzero redshiftzero merged commit 7e94937 into develop Nov 29, 2018
@redshiftzero redshiftzero deleted the fix-qa-loader branch November 29, 2018 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants