Functional pytest #3844
Closed
Functional pytest #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We decided during sprint planning to merge |
2 tasks
|
Hi @heartsucker, sorry for the long silence on this PR. We still are interested in moving towards more parallel execution of tests, and using the approach in this PR as a stepping stone towards that goal. However, many changes to functional tests, especially Tor support, have landed since you worked on this, and major PR surgery would be required. Our inclination would be to close this PR, and revisit when we prioritize test performance improvements. If you still have time for SecureDrop and would like to work on it again yourself, let us know, and we can set aside time in a future sprint to pair with you on it. |
|
Closing per above comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Work in progress
Description of Changes
Fixes #3836
Use pytest for functional tests
Testing
Checklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development container