Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest 2 electric boogaloo #3731

Merged
merged 9 commits into from
Aug 24, 2018
Merged

Pytest 2 electric boogaloo #3731

merged 9 commits into from
Aug 24, 2018

Conversation

heartsucker
Copy link
Contributor

Status

Ready for review

Description of Changes

Toward #2877.

More use of pytest fixtures.

Testing

make test TESTFILES=tests/test_journalist.py

Checklist

If you made changes to the server application code:

  • Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

@codecov-io
Copy link

codecov-io commented Aug 24, 2018

Codecov Report

Merging #3731 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3731   +/-   ##
========================================
  Coverage    84.76%   84.76%           
========================================
  Files           44       44           
  Lines         2757     2757           
  Branches       297      297           
========================================
  Hits          2337     2337           
  Misses         353      353           
  Partials        67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0c9f3...bc07997. Read the comment docs.

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :shipit:

@redshiftzero redshiftzero merged commit f922012 into develop Aug 24, 2018
@redshiftzero redshiftzero deleted the pytest-2-electric-boogaloo branch August 24, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants