Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.7.0] l10n: sync translations #3383

Merged
merged 19 commits into from May 9, 2018
Merged

[0.7.0] l10n: sync translations #3383

merged 19 commits into from May 9, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2018

Status

Ready for review

Description of Changes

Backport of #3377

Testing

These are new translations files (covered by a generic apparmor inclusion) and updates that can be verified if you speak the language by switching to the corresponding language using the menu. Ensuring there is no breakage because of placeholders incorrectly copied over can be done with:

  • bin/dev-shell bash
  • source bin/dev-deps
  • run_xvfb & run_redis & run_x11vnc & run_sass --watch & urandom
  • ./i18n_tool.py translate-messages --compile
  • setting config.py line SUPPORTED_LOCALES = ['ar','de_DE','es_ES','fr_FR','nb_NO','nl','pt_BR','zh_Hant','en_US','it_IT','tr', 'hi', 'ru']
  • running
$ PAGE_LAYOUT_LOCALES='ar,de_DE,es_ES,fr_FR,nb_NO,nl,pt_BR,zh_Hant,it_IT,tr,hi,ru' pytest -v --page-layout tests/pages-layout
...

Deployment

The new files will be added when the package is updated. There is no action required from the sysadmin point of view.

Checklist

If you made changes to the app code:

  • Unit and functional tests pass on the development VM

Loic Dachary added 19 commits May 9, 2018 19:16
localizers: Cecília do Lago, A. Nonymous, Cláudio Carvalho, communiaa, Jonas B. R, Erin McConnell, Bernardo Tonasse

Review: https://weblate.securedrop.club/user/communiaa (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit 8230e25)
localizers: Manuel D'Orso, Claudio Arseni, Beatrice Martini

Review: https://weblate.securedrop.club/user/Claudinux/ (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit 407683e)
localizers: foolfitz, H.-L. Lee, Jin Lin Wright, Shih-Chieh Ilya Li, Cheng-Chia Tseng, Chi-Hsun Tsai

Review: https://weblate.securedrop.club/user/jxtsai/ (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit cabb6e1)
localizers: Abhishek Jaiswal, Subham Banga, Drashti, Dev Singh, Muhammad Usman

Review: https://weblate.securedrop.club/user/drashti4/ (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit abcb61a)
localizers: Anna Skaja, Ettore Atalan, Eric H., kwadronaut

Review: https://weblate.securedrop.club/user/Atalanttore (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit b29a6b7)
localizers: Andrey, Maria Ovsyannikova, Eric H., Adham Kurbanov

Review: https://weblate.securedrop.club/user/xattabych/ (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit c5d68d3)
localizers: Thom, Anne M, kwadronaut, Yarno Ritzen

Review: https://weblate.securedrop.club/user/SilverXp/ (localizationlab)
        https://weblate.securedrop.club/user/kwadronaut (localizationlab)
        https://weblate.securedrop.club/user/AnneM (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit 7c4f995)
localizers: Alain-Olivier, Jean-Marc Manach, Michal Čihař, David, Loic Dachary

Review: https://weblate.securedrop.club/user/french.coordinator (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit df01f20)
localizers: T. E. Kalaycı, Volkan, tekrei

Review: https://weblate.securedrop.club/user/wakeup/ (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit 3f1f731)
localizers: Ali Boshanab, Jennifer Helsby, Ouss, Ahmad Gharbeia, ButterflyOfFire., Gabriele Kahlout, Thalia Rahme, kwadronaut, Jasmine Khalil, Ramy Raoof, Erin McConnell, Scharik Yousif

Review: https://weblate.securedrop.club/user/ramyraoof/ (localizationlab)
        https://weblate.securedrop.club/user/agharbeia/ (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit 18a417d)
localizers: Jose, Pablo Di Noto, Allan Nordhøy, Freddy Martinez, Daniel Arauz, Camille Fassett, Anatoli

Review: https://weblate.securedrop.club/user/pdinoto/ (localizationlab)
        https://weblate.securedrop.club/user/freddymartinez9 (FPF)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit 8be44e0)
localizers: Øyvind Bye Skille, Allan Nordhøy

Review: https://weblate.securedrop.club/user/kingu (localizationlab)

https://lab.securedrop.club/bot/securedrop.git
copied from 3bd099e

(cherry picked from commit 2cc0bde)
(cherry picked from commit 45cb8f7)
#3379

reverted a change at the last minute to resolve an upgrade problem
prior to the release of 0.7.0. This contains the following user facing
change:

 #: journalist_app/forms.py:62
-msgid "You can only upload JPG/JPEG or PNG image files."
+msgid "Upload images only."
 msgstr ""

Which was translated in the past and the translation was preserved,
allowing us to restore it without asking the localizers.

Relates to: #3379

(cherry picked from commit eab19aa)
@ghost ghost added the i18n Anything related to translation or internationalization of SecureDrop label May 9, 2018
@ghost ghost added this to the 0.7 milestone May 9, 2018
@ghost ghost requested review from conorsch, heartsucker, msheiny and redshiftzero as code owners May 9, 2018 17:20
@codecov-io
Copy link

Codecov Report

Merging #3383 into release/0.7 will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/0.7    #3383      +/-   ##
===============================================
- Coverage        85.81%   85.79%   -0.02%     
===============================================
  Files               34       34              
  Lines             2157     2154       -3     
  Branches           238      238              
===============================================
- Hits              1851     1848       -3     
  Misses             250      250              
  Partials            56       56
Impacted Files Coverage Δ
journalist_app/admin.py 87.33% <0%> (-0.25%) ⬇️
i18n_tool.py 96.15% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e76a2e...b5f1418. Read the comment docs.

@emkll emkll self-requested a review May 9, 2018 18:14
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dachary for porting these translations. Changes introduced are identical as those in #3377.

@emkll emkll merged commit 3b1be65 into freedomofpress:release/0.7 May 9, 2018
@emkll emkll mentioned this pull request May 11, 2018
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything related to translation or internationalization of SecureDrop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants