Add updater GUI #3300
Merged
Add updater GUI #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit runs check_for_updates on boot, and then runs the updater GUI if updates are needed. If updates are not needed, then nothing will happen. Note: in order to run this, the venv must already be set up, as the journalist/admin will run `./securedrop-admin tailsconfig` in order to update this on-boot hook. So assuming that the venv is configured in the on-boot hook is a safe assumption.
This is such that they can try again. For example, if they just fail to type in the sudo password, they might want to try again. If they get a scarier message they _can_ try again, though the strings warn the user in such a case just to go to their administrator.
This doesn't have a py extension because the name will appear in the Tails process bar, and it's nice to show simply SecureDropUpdater there.
(cherry picked from commit 9488aea)
(cherry picked from commit 9c67f0d)
(cherry picked from commit 4c68fcb)
(cherry picked from commit 02c68cf)
(cherry picked from commit e50d8b3)
(cherry picked from commit 8f0feb4)
(cherry picked from commit d9877b7)
redshiftzero
force-pushed
the
qt-journalist-updater
branch
from
82410e5 to
201f8b1
Compare
redshiftzero
force-pushed
the
qt-journalist-updater
branch
from
201f8b1 to
2f21951
Compare
This was referenced Apr 25, 2018
Merged
kushaldas
added a commit
that referenced
this pull request
Apr 25, 2018
As suggesed in #3300 (comment)
redshiftzero
force-pushed
the
qt-journalist-updater
branch
from
2f21951 to
2544046
Compare
redshiftzero
force-pushed
the
qt-journalist-updater
branch
from
2544046 to
3782f52
Compare
As suggesed in #3300 (comment)
This is because the file only is accessed by a single process at any one time. As such, it should be named a flag file for clarity.
Fixes #3310 no sizegrip
4 tasks
[qt-journalist-updater] Address remainder of review comments on #3300
|
Hey @emkll and @heartsucker, take a look at the latest (btw @emkll #3309 should also be good to go after a rebase) - I think this should resolve all the outstanding issues. Let's discuss how to proceed (0.7 vs 0.8) tomorrow. |
heartsucker
approved these changes
Apr 26, 2018
|
My concerns have been addressed, but there's not a "dismiss review" button, so my thumbs up should not be considered sufficient for merge. |
emkll
approved these changes
Apr 26, 2018
|
LGTM! Thanks for the quick fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #3076.
Changes proposed in this pull request:
Testing
./securedrop-admin tailsconfigDeployment
Users will need to re-run
./securedrop-admin tailsconfigto use this.But from that point forward,
securedrop-admin update,securedrop-admin setupandsecuredrop-admin tailsconfigwill be automated by the GUI.Checklist
If you made changes to the Updater GUI
make ci-lintpassespython3 test_gui.pypasses