Flash message fixes #1558
Flash message fixes #1558
Conversation
|
Also @ninavizz is going to want to check these for colors since I guessed for some since values weren't (aren't?) in the relevant issues. |
securedrop/source.py
Outdated
| "notification") | ||
| flash(Markup("""{svg}<div class="message"><strong>Success!</strong> | ||
| <p>Thank you for sourcing this information to us. | ||
| Please check-back later for replies. <a href="#codename-hint"> |
There was a problem hiding this comment.
'check-back' -> 'check back'
securedrop/source.py
Outdated
| "Thanks for submitting something to SecureDrop! Please check back later for replies.", | ||
| "notification") | ||
| flash(Markup("""{svg}<div class="message"><strong>Success!</strong> | ||
| <p>Thank you for sourcing this information to us. |
There was a problem hiding this comment.
'sourcing' -> 'sending'
securedrop/source.py
Outdated
| msg = Markup("""<div class="icon">{svg}</div> | ||
| <div class="message"><strong>Important!</strong><br> | ||
| <p>Thank you for exiting your session! Please select "New | ||
| Identity" from the green Onion button in the Tor browser, |
There was a problem hiding this comment.
delete comma at end of line
| <strong>Whew, it’s you! Now, the embarrassing part...</strong></br> | ||
| <p>Our servers experienced an unusual surge of new activity, when you last visited. This could | ||
| have been human activity, an automated attack, or just some random blip. To err on the side | ||
| of caution, we put a hold on sending all documents from that day, through to our journalists.</p> |
There was a problem hiding this comment.
'day, through' -> 'day through'
| of caution, we put a hold on sending all documents from that day, through to our journalists.</p> | ||
|
|
||
| <p>Now that we know you’re really a human, though, we’ll get your previous submission into the | ||
| hands of a journalist, straight away. We’re sorry for the delay. Please do check-back again |
There was a problem hiding this comment.
'journalist, straight away' -> 'journalist straight away'
There was a problem hiding this comment.
'check-back' -> 'check back'
| def test_svg_bad_path(self): | ||
| with source.app.app_context(): | ||
| with self.assertRaises(PathException): | ||
| util.svg('../../../../etc/hosts') |
| strong | ||
| color: #673466 | ||
| p | ||
| color: #555555 |
There was a problem hiding this comment.
It's probably best to store these hex color codes as variables in _variables.sass
There was a problem hiding this comment.
If we add these colors anywhere else, I'd do it, I feel like for the moment these are specific enough to the single place they're used to leave them here. Also, according to @ninavizz 's mock ups, we need to have text and link colors change which is actually going to require a chunk of alterations to how we structure the html/css if we want it to make sense.
"Fingerprint" icon is by Travis Avery from the Noun Project.
heartsucker
force-pushed
the
flash-fixes
branch
from
36a992f to
8e0a888
Compare
|
Ok, changes look good now. Merging... |
|
Thanks for cc'ing me @heartsucker — still getting my chops sharpened with this whole Terminal/Git/Unix/etc stuff, to check PRs... so, it'll likely not be until mid-week at the earliest, that I'll be able to look at PRs on my own. Until then—to meltdowns and the ultra-appreciated encouragement and help from @fowlslegs! :) |
Fixes #1526, #1525, and #1524.
Doesn't include adding the custom org name to one of the flashed messages.
Some of this was pending until after #1538 got merged. Y'know, not to pile too much into one PR.