Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed 'scary' words from wordlist #1546

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

heartsucker
Copy link
Contributor

Fixes #1541

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Most of these words definitely make sense to remove. I've added inline comments where I think they could be added back in.

@@ -617,8 +602,6 @@ bonnet
bonsai
bonus
bony
boogeyman
boogieman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think these can go back in

@@ -1012,7 +989,6 @@ chihuahua
childcare
childhood
childish
childless
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this can go back in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning on this one would a that a whistleblower could lose custody of a child as a result of their actions, and this word might be "triggering" in that regard.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm fair point, feel free to leave in

@@ -1107,7 +1081,6 @@ clinking
clip
clique
cloak
clobber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this can go back in

@@ -6216,7 +6074,6 @@ sporting
sports
sporty
spotless
spotlight
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this can go back in

@@ -7772,5 +7596,3 @@ zone
zoning
zookeeper
zoologist
zoology
zoom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These last two can go back in

@@ -898,7 +876,6 @@ catalyst
catalyze
catapult
cataract
catatonic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this can go back in

@@ -1117,8 +1090,6 @@ clothes
clothing
cloud
clover
clubbed
clubbing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think these can go back in

@@ -5079,7 +4960,6 @@ ranger
ranging
ranked
ranking
ransack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this can go back in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this one because leak -> police raid -> ransack seemed like too easy a jump. Could put it back it still.

@redshiftzero
Copy link
Contributor

(Note: removing 178 words from the list reduces entropy from 12.89 to 12.85 bits per word - a negligible change - so security-wise I think this is good to merge)

@redshiftzero
Copy link
Contributor

Looks good, merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants