-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed 'scary' words from wordlist #1546
removed 'scary' words from wordlist #1546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Most of these words definitely make sense to remove. I've added inline comments where I think they could be added back in.
securedrop/wordlist
Outdated
@@ -617,8 +602,6 @@ bonnet | |||
bonsai | |||
bonus | |||
bony | |||
boogeyman | |||
boogieman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think these can go back in
@@ -1012,7 +989,6 @@ chihuahua | |||
childcare | |||
childhood | |||
childish | |||
childless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this can go back in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reasoning on this one would a that a whistleblower could lose custody of a child as a result of their actions, and this word might be "triggering" in that regard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm fair point, feel free to leave in
securedrop/wordlist
Outdated
@@ -1107,7 +1081,6 @@ clinking | |||
clip | |||
clique | |||
cloak | |||
clobber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this can go back in
securedrop/wordlist
Outdated
@@ -6216,7 +6074,6 @@ sporting | |||
sports | |||
sporty | |||
spotless | |||
spotlight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this can go back in
securedrop/wordlist
Outdated
@@ -7772,5 +7596,3 @@ zone | |||
zoning | |||
zookeeper | |||
zoologist | |||
zoology | |||
zoom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These last two can go back in
securedrop/wordlist
Outdated
@@ -898,7 +876,6 @@ catalyst | |||
catalyze | |||
catapult | |||
cataract | |||
catatonic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this can go back in
@@ -1117,8 +1090,6 @@ clothes | |||
clothing | |||
cloud | |||
clover | |||
clubbed | |||
clubbing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think these can go back in
@@ -5079,7 +4960,6 @@ ranger | |||
ranging | |||
ranked | |||
ranking | |||
ransack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this can go back in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled this one because leak -> police raid -> ransack seemed like too easy a jump. Could put it back it still.
(Note: removing 178 words from the list reduces entropy from 12.89 to 12.85 bits per word - a negligible change - so security-wise I think this is good to merge) |
7283283
to
89bb895
Compare
89bb895
to
e0f900d
Compare
Looks good, merging! |
Fixes #1541