Redirect source to /lookup if visiting /generate and already logged in #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwplus
force-pushed
the
source_redirect
branch
from
69128f5 to
f847ccb
Compare
| # page, or inform them that they're logged in. | ||
| session.pop('logged_in', None) | ||
| if logged_in(): | ||
| flash("You were redirected from {} because you are already logged in.".format(url_for('generate')), "notification") |
There was a problem hiding this comment.
I think a better message here would be "You were redirected because you are already logged in. If you want to create a new account, you should log out first".
pwplus
force-pushed
the
source_redirect
branch
from
f847ccb to
a2812b1
Compare
|
I intend to write these tests in my free time over the next week. |
| # page, or inform them that they're logged in. | ||
| session.pop('logged_in', None) | ||
| if logged_in(): | ||
| flash("You were redirected because you are already logged in. If you want\ |
There was a problem hiding this comment.
Personally, for long strings, I prefer to use Python's line continuation behavior, which merges multiple quoted strings together automatically. Like this:
flash("You were redirected because you are already logged in. If you want"
"to create a new account, you should log out first.", "notification")
|
@pwplus I added some more line comments. If you need help writing the additional tests, let me know! |
pwplus
force-pushed
the
source_redirect
branch
3 times, most recently
from
69d5753 to
7d29887
Compare
When a source is already logged in, clicking the back button could log them out and generate a new codename. This could cause the source to lose their original codename if it was not memorized yet. This commit will redirect the source to the look page if they accidentally go back to the generate page when logged in. It also adds an explicit logout button when the source is logged in. This adds both confidence and professionalism to the appearance.
pwplus
force-pushed
the
source_redirect
branch
from
7d29887 to
670974c
Compare
|
Ah, I missed that you'd implemented the functional tests because you rebased. Lgtm! |
garrettr
added a commit
that referenced
this pull request
Nov 17, 2015
Redirect source to /lookup if visiting /generate and already logged in
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to log out at /logout.
Add test to ensure that /generate handles users who are already logged in appropriately
Improve test for generate when already logged in
Add log out button to source_templates/base.html
This is the exact same thing as this PR, but squashed and rebased to the current source since mine was 2 months outdated: #1080
I ended up getting the job at the company I interviewed for and had to get managerial approval before I could continue working on this project. Luckily, I got managerial approval!