You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Firefox is going to hit major version 100 soon, which means our regexes that match against a 2 digit major version will stop working.
Steps to Reproduce
In source.js:
const TBB_UA_REGEX = /Mozilla\/5\.0 \((Windows NT 10\.0|X11; Linux x86_64|Macintosh; Intel Mac OS X 10\.[0-9]{2}|Windows NT 10\.0; Win64; x64|Android; Mobile); rv:[0-9]{2}\.0\) Gecko\/20100101 Firefox\/([0-9]{2})\.0/
const ORFOX_UA_REGEX = /Mozilla\/5\.0 \(Android; Mobile; rv:[0-9]{2}\.0\) Gecko\/20100101 Firefox\/([0-9]{2})\.0/;
The current TBB UA is Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0. Presumably it'll be s/91\.0/100.0/g whenever the time comes.
Expected Behavior
>>> "Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0".match(TBB_UA_REGEX)
Array(3) [ "Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0", "X11; Linux x86_64", "91" ]
Actual Behavior
>>> "Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0".match(TBB_UA_REGEX)
null
Comments
Given that we specifically look for TBB and Orfox, I don't think we need to rush to meet Chrome's March release date nor Firefox's May one because TBB will be on Firefox 91 ESR for quite a while more.
The text was updated successfully, but these errors were encountered:
Per <https://hacks.mozilla.org/2022/02/version-100-in-chrome-and-firefox/>,
Firefox will soon hit version 100, which will break any regex that is
matching against a 2-digit version, like we do.
Switch the regex to match against 3-digit versions as well, which should
keep us going for another 900 versions.
Fixes#6276.
Description
See https://hacks.mozilla.org/2022/02/version-100-in-chrome-and-firefox/.
Firefox is going to hit major version 100 soon, which means our regexes that match against a 2 digit major version will stop working.
Steps to Reproduce
In source.js:
The current TBB UA is
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0
. Presumably it'll bes/91\.0/100.0/g
whenever the time comes.Expected Behavior
Actual Behavior
Comments
Given that we specifically look for TBB and Orfox, I don't think we need to rush to meet Chrome's March release date nor Firefox's May one because TBB will be on Firefox 91 ESR for quite a while more.
The text was updated successfully, but these errors were encountered: