Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n_tool.py list-translators is broken by multiple syncs in a release #5570

Closed
rmol opened this issue Oct 9, 2020 · 0 comments · Fixed by #5571
Closed

i18n_tool.py list-translators is broken by multiple syncs in a release #5570

rmol opened this issue Oct 9, 2020 · 0 comments · Fixed by #5571
Assignees
@rmol
Labels
goals: speed up release process i18n Anything related to translation or internationalization of SecureDrop

Comments

@rmol
Copy link
Contributor

rmol commented Oct 9, 2020

Description

The list-translators function has a brittle heuristic for determining when to start gathering translator contributions; it looks backward through the git history for the most recent l10n: sync message. If we have to sync more than once for a release, to incorporate source string feedback or whatever, then it will miss contributions since the last release and before that sync.
@rmol rmol self-assigned this Oct 9, 2020
@rmol rmol mentioned this issue Oct 9, 2020
Merged
2 tasks
@rmol rmol added the i18n Anything related to translation or internationalization of SecureDrop label Dec 11, 2020
@rmol rmol mentioned this issue Dec 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmol rmol

Labels
goals: speed up release process i18n Anything related to translation or internationalization of SecureDrop
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve i18n_tool.py list-translators, update-from-weblate freedomofpress/securedrop
1 participant
@rmol