Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n_tool.py list-translators can miss contributions #5427

Closed
rmol opened this issue Jul 29, 2020 · 1 comment
Closed

i18n_tool.py list-translators can miss contributions #5427

rmol opened this issue Jul 29, 2020 · 1 comment
Labels
i18n Anything related to translation or internationalization of SecureDrop

Comments

@rmol
Copy link
Contributor

rmol commented Jul 29, 2020

Description

The list-translators action of i18n_tool.py only looks back until the last recognized sync from develop. If there were contributions between that and the previous release, they will not be credited.

Steps to Reproduce

Compare the output of make list-translators to the Weblate translator credits report.

Expected Behavior

That all contributions could be credited.

Actual Behavior

Right now, Weblate will credit some contributions to Swedish (possibly others) that i18n_tool.py does not.

Comments

Right now the commit range examined for contributions is determined automatically by finding the most recent sync, but we could permit the specification of the interval.

Taking a step back, we could consider whether it's really useful to maintain this code, instead of just using the Weblate report to credit translators in release communications. Gathering credits from the git history means we're not tied to Weblate, but should we ever migrate to another translation platform, it would almost certainly have an equivalent report.

@eloquence eloquence added the i18n Anything related to translation or internationalization of SecureDrop label Dec 11, 2020
@rmol
Copy link
Contributor Author

rmol commented Dec 11, 2020

Reported again, by the same person, in #5570. 🙄 And it's been fixed.

@rmol rmol closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything related to translation or internationalization of SecureDrop
Projects
None yet
Development

No branches or pull requests

2 participants