Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Delete Reply?" confirmation dialog needs... work. #5152

Open
4 tasks
ninavizz opened this issue Mar 11, 2020 · 1 comment
Open
4 tasks

"Delete Reply?" confirmation dialog needs... work. #5152

ninavizz opened this issue Mar 11, 2020 · 1 comment

Comments

@ninavizz
Copy link
Member

Description

See dialog in lower-right of screenshot.
image

Steps to Reproduce

Delete a reply.

Expected Behavior

That it not look icky.

Actual Behavior

That it looks icky.

Comments

Zeplin forthcoming; but short of that it needs:

  • A dropshadow behind the box to enhance recognition of the window
  • A solid-primary button styling with the urgent coral, vs an outline button next to a link
  • Ohai even padding around all the edges
  • Preferred grimace=blue as the outline coloring for the dialog frame, but that's part of the TBD with the Zeplin.

TBH, I'd really prefer to just clean-up the Replies area, per this Zeplin... but that's a bigger project.
@rocodes
Copy link
Contributor

rocodes commented May 4, 2020

Bumping for 1.3.0 QA visibility, relevant for testing #5096

@rocodes rocodes mentioned this issue May 4, 2020
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ninavizz @rocodes