-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Journalist API responses include Set-Cookie/Vary headers #3876
Labels
Comments
@heartsucker are you still working on this or i can give it a try? |
I'm not actively working on it, so if you'd like to give it a try that'd be very helpful! |
batman on it. |
I am not able to give it as much time as i thought i would. So, if anyone wants to take this, they are free to |
rjmackay
added a commit
to rjmackay/securedrop
that referenced
this issue
Nov 24, 2018
Implement a custom session interface that never sets session cookies on API requests Fixes freedomofpress#3876
rjmackay
added a commit
to rjmackay/securedrop
that referenced
this issue
Nov 24, 2018
Implement a custom session interface that never sets session cookies on API requests Fixes freedomofpress#3876
5 tasks
rjmackay
added a commit
to rjmackay/securedrop
that referenced
this issue
Nov 25, 2018
Implement a custom session interface that never sets session cookies on API requests Fixes freedomofpress#3876
rjmackay
added a commit
to rjmackay/securedrop
that referenced
this issue
Dec 2, 2018
Implement a custom session interface that doesn't save sessions for API requests Fixes freedomofpress#3876
rjmackay
added a commit
to rjmackay/securedrop
that referenced
this issue
Dec 2, 2018
Implement a custom session interface that doesn't save sessions for API requests Fixes freedomofpress#3876
rjmackay
added a commit
to rjmackay/securedrop
that referenced
this issue
Dec 7, 2018
Implement a custom session interface that doesn't save sessions for API requests Fixes freedomofpress#3876
kushaldas
pushed a commit
that referenced
this issue
Sep 25, 2019
Implement a custom session interface that doesn't save sessions for API requests Fixes #3876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The API includes the
Set-Cookie
header andVary: Cookie
when they should not as they are not relevant to accessing the API.Steps to Reproduce
In one terminal:
make dev
.In another:
http HEAD localhost:8081/api/v1
Expected Behavior
Actual Behavior
Comments
I have tried implementing and override to
SecureSessionInterface
that doesn't set a cookie if the endpoint matches the API endpoint, but... no dice so far.The text was updated successfully, but these errors were encountered: