Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reply refactor] Also encrypt replies to submission key #3673

Closed
redshiftzero opened this issue Jul 31, 2018 · 3 comments
Closed

[reply refactor] Also encrypt replies to submission key #3673

redshiftzero opened this issue Jul 31, 2018 · 3 comments

Comments

@redshiftzero
Copy link
Contributor

Description

Replies are currently encrypted only to the source key. This makes reading prior replies impossible from the journalist's side, unless they are diligent and keep a record. These replies should be stored on the SecureDrop server encrypted to both the source key and the submission key.

Epic: #3097

@redshiftzero
Copy link
Contributor Author

For #3674, we need a lightweight way to indicate whether or not a reply was encrypted to the submission key or just the source key. One sensible approach would be in this ticket to add a column allow_journo_download (or even a better name) to the replies table, that we set to True going forward. This will enable us to gracefully handle #3673.

@emkll
Copy link
Contributor

emkll commented Aug 1, 2018

Good news ! It turns out this functionality has been implemented, at least as far back as 0.3 release:

It also appears to have integration test coverage:
https://github.com/freedomofpress/securedrop/blob/develop/securedrop/tests/test_integration.py#L282

For the sake of completeness, I can add a small assert in https://github.com/freedomofpress/securedrop/blob/develop/securedrop/tests/test_crypto_util.py#L125 to ensure the JOURNALIST_KEY can decrypt the submission.

@redshiftzero Anything else I should add to close out the ticket?

@redshiftzero
Copy link
Contributor Author

excellent! since there's integration test coverage of the reply being successfully decrypted by the submission key, we're good to close, thanks @emkll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants